Project

General

Profile

Feature #127

[Box] Support v type URLs

Added by jacobk 15 days ago. Updated 11 days ago.

Status:
Closed
Priority:
Low
Assignee:
-
Start date:
09/13/2022
Due date:
% Done:

100%

Estimated time:

Description

All it takes to do this is to add "https://.app.box.com/v/" to the matched URL patterns (in addition to "https://.app.box.com/s/"). I'm not sure what the difference between these 2 URL schemes is supposed to be (I haven't looked at how the official app displays them.), but the existing fix seems to work well with the v URLs already.

I have uploaded a commit that adds these patterns here: https://codeberg.org/JacobK/hydrilla-fixes-bundle/commit/42a4a3998c54a0faa30e0d9bb829a75055199fb6

(While looking for public test cases for this, I also found an f type URL (https://dronepadmedia.app.box.com/f/a14b5488396345c3ab0466d805636b83), a folder (https://app.box.com/s/5fb14p1yyjhak97rgbmksy81a2f5nehn), and a folder inside a folder (https://app.box.com/v/b00ks).)

History

#1

Updated by jacobk 15 days ago

Oops, I didn't change the version number of the mapping_and_resource, here's an updated commit: https://codeberg.org/JacobK/hydrilla-fixes-bundle/commit/b24bcf3346c3d2662605821886da7351f6704974

#2

Updated by koszko 11 days ago

  • Subject changed from [Box] Support s type URLs to [Box] Support v type URLs

Thanks, I applied your change.

I am unfortunately not going to work on supporting folders rn as I need to prioritize other things. Feel free to open a new issue in case you resolve it by yourself, I'm closing this one :)

#3

Updated by koszko 11 days ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

Also available in: Atom PDF