Project

General

Profile

Site script request/donation #128

Dr. McDougall (site for recipes)

Added by jacobk 15 days ago. Updated 8 days ago.

Status:
Closed
Priority:
Low
Assignee:
-
Start date:
09/13/2022
Due date:
% Done:

100%

Estimated time:

Description

This site seems to work mostly fine if noscript elements are not rendered, so it can be fixed to some extent with a blank payload.

For example https://www.drmcdougall.com/recipes/ shows images but a big banner covers the whole screen making the site unusable. The banner and images seem to be part of noscript elements, so simply using an empty payload to disable noscript element rendering makes the banner go away, but it also breaks the images.

When loading the site with noscript elements rendered, document.querySelector("div.floating-action-button-container").remove(); can be used in the developer console to remove the banner, and then the images will still be there.

I'm not sure what the best way to handle a site like this is (where we don't really need code but just an empty payload, more like a configuration change really, or where it would be useful to have most noscript tags rendered but one removed), but I've uploaded a fix with a blank payload here: https://codeberg.org/JacobK/hydrilla-fixes-bundle/commit/7ba33cd09d7d4508948594c648d03a0a2e0ce624

History

#1

Updated by koszko 11 days ago

Thanks.

I'd say empty payloads are OK. Well, not in this particular case because I just wrote and uploaded an improved fix that makes the images show up properly ^^ But in general I'd actually consider empty payloads neater that having an additional configuration option that's only useful on rare occasions

#2

Updated by koszko 11 days ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed
#3

Updated by jacobk 8 days ago

I was thinking of a configuration change to render noscript tags while still using a payload, so you could then use a script to remove the one problematic tag. But this works too.

Also available in: Atom PDF