Haketilo

jacobk wrote:

Hello, I just made an account here. I've been looking for an extension like this for a while, so thanks for making this!

Hi Jacob! Thanks for joining :)

In the past I've used a combination of LibreJs, NoScript to block nonfree/unwanted JavaScript, and various extensions (Hachette, Greasemonkey, LocalCDN, etc.) to replace functionality on sites that depend on JavaScript to function. In many cases, I whitelist scripts that I know are free (such as the scripts on archive.org) in LibreJS, but often when websites update I have to go through and whitelist all the scripts again. So, I had an idea to make an extension that contains the non-LibreJS-accepted scripts at archive.org and sends them when they are blocked in LibreJS. Unfortunately, I couldn't get it to work, and I think because extension scripts run in a different context than page scripts (and I was trying to combine extension scripts and page scripts together), which I think is the same issue with Greasemonkey mentioned in the wiki here
(I assume Greasemonkey's context problem doesn't apply to Haketilo, since it's mentioned as a comparison.).

Correct. We went great lengths to inject local scripts into the actual page and to prevent page's CSP rules from blocking those scripts.

Now, with Haketilo, as a test, I tried downloading to 2 scripts served at https://accounts.fedoraproject.org and putting them in a bag, and then telling Haketilo to execute them on https://accounts.fedoraproject.org. Unfortunately, I get an error "Uncaught TypeError: p is undefined" in the console. So, the question is: why? There are no "onclick" or similar elements in the HTML (unless I'm missing something which is quite possible, but I think LibreJS would show it), which I think is what issue #7 refers to.

I tried reproducing your issue and the exact error happens if I try to load Bootstrap before JQuery. If I reverse the order, it works properly (actually, this alterantive fix would be worth adding to the list of official scripts!).

The thing is, Haketilo injects scripts in the same order they appear within a bag. In this case one of Fedora Accounts' scripts (Bootstrap) depends on the other one (JQuery) and thus should be placed after it in the bag.

Currently in Haketilo settings page there's yet no facility to conveniently reorder bag's scripts, so you'll just need to remove Bootstrap from the bag and re-add it (it will then appear after JQuery).

I think this is relevant to this issue since automatically saving/installing JavaScript on a page would be most useful if the scripts can run as is.

True. I updated this task's description to mention a few cases where we already know this won't work properly. Despite these, I expect a big subset of websites to not have such issues.

Btw, I am sad to inform that this feature is not of very high priority. I a (not-yet-public) Memorandum of Understanding document we'll be signing with NLnet it landed as an optional feature that's not part of the work our current monetary grant covers... You could still contribute the code yourself if you want ;)