Project

General

Profile

Feature #22

supplement the build script with a makefile, also produce zipped artifacts

Added by koszko about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
07/01/2021
Due date:
% Done:

100%

Estimated time:

Description

Right now building is performed with build.sh mozilla or build.sh chromium. These produce directories with built extension contents. Makefile could be used on top of current build script to additionally facilitace cleaning the workspace and generating the extension as .zip or .xpi.

History

#1

Updated by jahoti about 2 years ago

Potentially obsoleted by #47

#2

Updated by koszko about 2 years ago

Unless we decide to keep the old build script and maintain both. Consider packaging of the extension for distros.
Having build.sh would greatly reduce the number of build dependencies.

Anyway, a JS-based build system could still be wrapped into a Makefile

#3

Updated by koszko about 2 years ago

  • Subject changed from supplement the build script with a makefile, also produce zipped arifacts to supplement the build script with a makefile, also produce zipped artifacts
#4

Updated by jahoti almost 2 years ago

  • Description updated (diff)
  • Assignee set to jahoti
#5

Updated by jahoti almost 2 years ago

  • % Done changed from 0 to 50

The modified build system on the jahoti-update branch now has support for zip and crx generation (using Chromium; CRX2 is very outdated and CRX3 adds significant complications).

A make file will be coming soon.

#6

Updated by jahoti almost 2 years ago

  • Status changed from New to Feedback
  • % Done changed from 50 to 100

An implementation of this is in the build-sys branch; it may need to be modified.

#7

Updated by koszko almost 2 years ago

jahoti wrote:

An implementation of this is in the build-sys branch; it may need to be modified.

You did a ton of good work. Thank you a lot :)
I'll look into it now

EDIT

Is there any relation between jahoti-update and build-sys branches? I suppose I should just merge both, right?

Also, I read somewhere that iceweasel-uxp dropped all support for WebExtensions. Is there something I don't know or can we remove it from the TARGETs list?

EDIT2

For now I just merged build-sys. I'll also merge the build.sh -> build.sh + lib_build.sh split. It seems jahoti-update's test code will make sense merging once we decide how to implement an actual "make test" target, right?

#8

Updated by koszko almost 2 years ago

koszko wrote:

EDIT2

For now I just merged build-sys. I'll also merge the build.sh -> build.sh + lib_build.sh split. It seems jahoti-update's test code will make sense merging once we decide how to implement an actual "make test" target, right?

The split didn't make sense merging, after all. I did, however, integrate Jahoti's test code (by copy-pasting) and connected it to make test as described in #66. This is on the koszko branch

#9

Updated by jahoti almost 2 years ago

I just realized there was an edit- sorry I didn't respond!

In case you didn't work out what happened, build-sys was a complete restart of the generalized build system using a configure/make system instead of a re-engineered build script. The only thing still to be carried over is support for building CRX files, and that's only for want of a browser-independent make target name to use.

#10

Updated by koszko over 1 year ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF