Project

General

Profile

Feature #28

split options_main.js into several smaller files

Added by koszko 5 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Start date:
07/01/2021
Due date:
% Done:

10%

Estimated time:

Description

This file is betting bigger and bigger...

History

#1

Updated by koszko 4 months ago

  • % Done changed from 0 to 10
#2

Updated by koszko 3 months ago

Discussion moved from #15

Since long-term we're not really planning to allow our scripts to run together with page's ones (i.e. "allow site's scripts" is going to exclude "inject our scripts"),

My mistake- I assumed that was enabled intentionally! Should I play with the options page to try and ensure that can't be done[...]?

Feel free to do this if you want :)
Keep in mind, however, options_main.js is currntly the most tangled script file in Hachette

Perhaps I'll start on that issue first :/.

You know what? We could leave cleaning-up of options_main.js for later, possibly do it together with the scripts/bags/pages redesign or storage redesign. Right now I can quickly make this little change you suggested since I already know that code. And you could instead focus (for example) on the testing facility you already started working on :)
Of course, if you decide to work on this issue anyway, you're still welcome

#3

Updated by jahoti 3 months ago

Right now I can quickly make this little change you suggested since I already know that code. And you could instead focus (for example) on the testing facility you already started working on :)

That seems like a better solution than learning something that's going to be reworked soon enough anyway!

Also available in: Atom PDF