Project

General

Profile

Feature #44

Load in default settings using the build system

Added by jahoti 7 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Start date:
07/06/2021
Due date:
% Done:

100%

Estimated time:

Description

Currently default settings are integrated into the source code, which makes it difficult to add or modify the built-in scripts. It would be significantly easier if the build process automatically integrated these from an exported file.

History

#1

Updated by jahoti 7 months ago

  • Status changed from New to In Progress
  • Assignee set to jahoti
  • % Done changed from 0 to 100

Patch pushed to git; awaiting acceptance/rejection from master branch.

#2

Updated by koszko 7 months ago

Perhaps we could load default_settings.json using XMLHttpRequest and this way reduce the complexity of build system and the amount of sed trickery?

Everything seems good, though. Accepting.

#3

Updated by jahoti 7 months ago

That would be a very, very good idea (albeit much less relevant if the build system is rewritten in JS).

#4

Updated by koszko 7 months ago

Btw, I am considering maintaining old build.sh alongside the new build.html. Plus, IMHO, changing to use XMLHttpRequest would be a good idea in case of the JS build system, too

#5

Updated by jahoti 7 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
#6

Updated by jahoti 7 months ago

  • Status changed from Resolved to Feedback
#7

Updated by jahoti 7 months ago

  • Status changed from Feedback to In Progress
#8

Updated by jahoti 7 months ago

  • Status changed from In Progress to Feedback
#9

Updated by jahoti 7 months ago

  • Status changed from Feedback to Resolved
#10

Updated by koszko about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF